getElement is used and Cannot add Field like this (use addField Exception)

atk4 / report

Reporting extension for Agile Data

https://agiletoolkit.org/

MIT License

3 stars 6 forks source link

Closed gowrav-vishwakarma closed 4 years ago

gowrav-vishwakarma commented 5 years ago

Need to use getField but doing that is getting the second issue: Exception from data/src/Model@add method 'You should always use addField() ...'

PS. getElement is also used in other places in report repo.

romaninsh commented 5 years ago

i think those issues are unrelated but both have to be fixes.

DarkSide666 commented 5 years ago

To be compatible with new atk4/data versions we have to replace getElement with getField.

gowrav-vishwakarma commented 5 years ago

Done the replacing and created a pull request, for now just in GroupModel. But still, the marked line has issues.