search

atk4 / schema

Few classes built on top of Agile Data that can take care of your SQL database schema
https://agiletoolkit.org/
MIT License
4 stars 5 forks source link

Make 2.0.1 release #33

Closed mvorisek closed 4 years ago

mvorisek commented 4 years ago

Is it possible to make 2.0.1 release (to include the 29 and 31 issues)?

DarkSide666 commented 4 years ago

2.0.1 released

mvorisek commented 4 years ago

@DarkSide666

Please check the release source branch.

Compare https://github.com/atk4/schema/blob/2.0.0/composer.json vs https://github.com/atk4/schema/blob/2.0.1/composer.json

The new 2.0.1 requires "atk4/dsql": "dev-develop" which does not seem to be right (and it can not be installed by default by composer if the standard stability is configured)

Even if "minimum-stability": "dev" is set the 2.0.1 is not installable. I would consider replacing the 2.0.1 release with a new one (as this can not be installed nowhere, as it was not possible to install)

It would be good to test clean composer install before any package is released.

mvorisek commented 4 years ago

And include #34 in that release if possible. Thanks.

DarkSide666 commented 4 years ago

34 merged in develop.

I will make new minor release, but probably will not manage to do that today.

DarkSide666 commented 4 years ago

2.0.2 release is out now

mvorisek commented 4 years ago

@DarkSide666 Thanks! A small question - shouldn't this package require atk4/data? This package is used in the main Migration class, see https://github.com/atk4/schema/blob/develop/src/Migration.php#L6 If this package is required not for production any project, it can be put into dev dependencies, but is there any reasoning to not requiring libs that are actually required?