search

atk4 / schema

Few classes built on top of Agile Data that can take care of your SQL database schema
https://agiletoolkit.org/
MIT License
4 stars 5 forks source link

Add type transcoding #9

Closed abbadon1334 closed 5 years ago

abbadon1334 commented 5 years ago

Review #8 some code, add more specific comment and change code formatting

codecov[bot] commented 5 years ago

Codecov Report

Merging #9 into develop will decrease coverage by 6.15%. The diff coverage is 52.08%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop       #9      +/-   ##
=============================================
- Coverage      72.33%   66.18%   -6.16%     
- Complexity       129      146      +17     
=============================================
  Files              5        5              
  Lines            300      343      +43     
=============================================
+ Hits             217      227      +10     
- Misses            83      116      +33
Impacted Files Coverage Δ Complexity Δ
src/Migration/SQLite.php 100% <ø> (ø) 1 <0> (ø) :arrow_down:
src/MigratorConsole.php 0% <0%> (ø) 4 <1> (+1) :arrow_up:
src/Migration/MySQL.php 90.9% <100%> (ø) 3 <0> (ø) :arrow_down:
src/Migration.php 65.78% <57.5%> (-7.51%) 99 <14> (+16)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b856ea0...d675830. Read the comment docs.

abbadon1334 commented 5 years ago

correct requested changes of #8 @DarkSide666 @romaninsh