atk4 / ui

Robust and easy to use PHP Framework for Web Apps
https://atk4-ui.readthedocs.io
MIT License
440 stars 105 forks source link

Currency symbols for multi-currency apps #153

Open DarkSide666 opened 7 years ago

DarkSide666 commented 7 years ago

Currently we have currency symbol property in UI_Persistence model. That's fine while we only have one currency in app, but we need a solution how to work in multi-currency apps.

For example, in TableColumn/Money we could have property currency and if it is set then it takes precedence. If it is not set (by default), then it uses currency symbol from UI_Persistence.

Maybe currency symbol should not be in UI_Persistence at all because it's not 100% localization thing. More likely adding it is task for formatters (TableColumn/Money or FormField/Money).

romaninsh commented 7 years ago

We need a different field / column / formfield to have a combined money+currency support. I can work on that but it would be an add-on.