search

atk4 / ui

Robust and easy to use PHP Framework for Web Apps
https://atk4-ui.readthedocs.io/en/stable/
MIT License
447 stars 106 forks source link

ScopeBuilder must support load/save #1843

Open mkrecek234 opened 2 years ago

mkrecek234 commented 2 years ago

demo https://dev.agiletoolkit.org/demos/form-control/scope-builder.php

Currently it outputs Unexpected non-scalar value on Save.

mvorisek commented 2 years ago

The problem is https://github.com/atk4/ui/pull/1730. How much is this important to you?

Previously, it used php serialization, which is a security problem, thus the ScopeBuilder save support was removed until it will be fixed.

mkrecek234 commented 8 months ago

@mvorisek Sorry for opening a duplicate before and thanks for removing.

I played with scopebuilder and have submitted a fix for at least making scopebuilder and its demo work. We can insert a security warning in the demo or in the ScopeBuilder class to make people aware. Please see commit https://github.com/atk4/ui/tree/fix_scopebuilder

mvorisek commented 8 months ago

I am not interested to pursue ScopeBuilder as it does not align my interests. If you will, make your fix passing CI.

mkrecek234 commented 8 months ago

@mvorisek CI except Behat test passes, still trying to get Behat adjusted to the improved demo which shows an example of real filtering on a crud. If you have a hint on how to move the Scope Builder behat test to the filter modal which first has to be open, rather than looking for the form control on the main page, very welcome.

mvorisek commented 8 months ago

Split that into 2 PRs. One to fix this issue with #1730 uncommented - you can reuse that PR if you want (restore branch and reopen it).

Once fixed, then let's add the filter incl. Behat.