atk4 / ui

Robust and easy to use PHP Framework for Web Apps
https://atk4-ui.readthedocs.io
MIT License
443 stars 106 forks source link

Do not handle exception in UserAction ModalExecutor #2008

Closed mvorisek closed 1 year ago

mvorisek commented 1 year ago

based on rebased #1328 PR previously closed

tested with data-action/jsactions2.php multistep action and panel/VP demos, all can handle an exception using modal

in https://github.com/atk4/ui/pull/1328#issuecomment-650577080 I have explained the reasons, we should never step forward on an error, the current handling of unhandled exceptions (Throwable in general) in atk4/ui is very good, realiable and tested