search

atk4 / ui

Robust and easy to use PHP Framework for Web Apps
https://atk4-ui.readthedocs.io
MIT License
440 stars 105 forks source link

Grid IPP change is broken #2016

Closed mkrecek234 closed 1 year ago

mkrecek234 commented 1 year ago

Check https://dev.agiletoolkit.org/demos/collection/grid.php and try to change the Items per Page to 25.

Error: Atk4\Ui\Exception: Not sure what to do with argument

mvorisek commented 1 year ago

in v4.0 it is working - https://ui.atk4.org/demos/collection/grid.php

needs a Behat test

mkrecek234 commented 1 year ago

@mvorisek Even if you raised now the bar to enforce behat tests, I cannot provide this, as it drives efforts to fix newly introduced bugs significantly, even though the fix is simply like in this case. This bug is really annoying, as it destroys the IPP functionality simply. So I would welcome either a merge by you, or any contribution by you to make it ready-to-merge also based on your lifted requirements.