search

atk4 / ui

Robust and easy to use PHP Framework for Web Apps
https://atk4-ui.readthedocs.io
MIT License
440 stars 105 forks source link

Fix Grid IPP selector #2017

Closed mkrecek234 closed 1 year ago

mkrecek234 commented 1 year ago

fix #2016

mvorisek commented 1 year ago

needs a Behat test and explanation why set should be done using string, also do not forget, IPP must be definitely typecasted with UI persistence :)

mkrecek234 commented 1 year ago

@mvorisek Even if you raised now the bar to enforce behat tests, I cannot provide this, as it drives efforts to fix newly introduced bugs significantly, even though the fix is simply like in this case. This bug is really annoying, as it destroys the IPP functionality simply. So I would welcome either a merge by you, or any contribution by you to make it ready-to-merge also based on your lifted requirements.

mvorisek commented 1 year ago

Michael, adding a Behat test is not so complicated, but it is needed to prevent such bug from happening again.

Also please understand the fix is not correct as explained in my post above.

mvorisek commented 1 year ago

Thank you @mkrecek234, no one can break it now :)