search

atk4 / ui

Robust and easy to use PHP Framework for Web Apps
https://atk4-ui.readthedocs.io
MIT License
440 stars 105 forks source link

Fix UploadImage::clearThumbnail default image reset #2027

Closed DarkSide666 closed 1 year ago

DarkSide666 commented 1 year ago

defaultSrc property should also be used in clearThumbnail method if no thumbnail is passed as method argument.

mvorisek commented 1 year ago

Am I right the defaultSrc is/was working, but not when/with clearThumbnail method only?

Also please name the PRs better, but still <70 chars, to be self explainatory in the changelog. No RTM label needed, if PR is not RTM, mark is as draft.

DarkSide666 commented 1 year ago

Comments addressed.

CodeCov has slight delay, but now it shows correct +0.30%