search

atk4 / ui

Robust and easy to use PHP Framework for Web Apps
https://atk4-ui.readthedocs.io
MIT License
440 stars 104 forks source link

Add favicon.ico to demos #2099

Closed abbadon1334 closed 10 months ago

mvorisek commented 10 months ago

In many cases the demos/ are not HTTP root path (/). You probably tried to fix missing favicon reported by a browser, in official hosted demos you should probably add the favicon in the Docker deploy script. If ok with you, let's close this PR.

abbadon1334 commented 10 months ago

In many cases the demos/ are not HTTP root path (/). You probably tried to fix missing favicon reported by a browser, in official hosted demos you should probably add the favicon in the Docker deploy script. If ok with you, let's close this PR.

you are right we already added it to deploy, i noticed it running the demos and i open the PR.