Upgrade PHPStan to v1.11.1

atk4 / ui

Robust and easy to use PHP Framework for Web Apps

https://atk4-ui.readthedocs.io

MIT License

439 stars 104 forks source link

Upgrade PHPStan to v1.11.1 #2205

Closed DarkSide666 closed 1 month ago

DarkSide666 commented 1 month ago

fix #2201

mvorisek commented 1 month ago

I am waiting on a new phpstan release because of https://github.com/phpstan/phpstan-strict-rules/commit/8afd4af32bbff7b1f6df3d42bda45b2e661ba297 and https://github.com/phpstan/phpstan/issues/10893

DarkSide666 commented 1 month ago

OK great. But this one probably should be made as separate PR here? https://github.com/atk4/ui/pull/2205/files#diff-6f19df6a6307a48db0940e6897591fb08776d2db8a6134737aa708defdb5c92dR402

mvorisek commented 1 month ago

We can, but we should not land the src/Persistence/Ui.php changes like proposed here, we can baseline then, but I prefer to wait for the next phpstan release...