codecov-io
commented
5 years ago Codecov Report
Merging #283 into master will increase coverage by
0.05%. The diff coverage is100%.
@@ Coverage Diff @@
## master #283 +/- ##
==========================================
+ Coverage 87.39% 87.44% +0.05%
==========================================
Files 13 13
Lines 1491 1497 +6
Branches 343 346 +3
==========================================
+ Hits 1303 1309 +6
Misses 131 131
Partials 57 57| Impacted Files | Coverage Δ | |
|---|---|---|
| camelot/core.py | 87.83% <100%> (+0.2%) |
:arrow_up: |
| camelot/handlers.py | 90.24% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 8ea4ec3...8446271. Read the comment docs.
vinayak-mehta
This PR fixes https://github.com/socialcopsdev/camelot/issues/277
c019e58 is fairly easy, and is useful for some cases where the
Tableobjects have got mixed up for some reason, or where reversing them is useful.8446271 I'm less sure about. When I opened the issue I thought I'd found a PDF that causes camelot to return tables in an order not defined in the PDF. I can't reproduce this, so I can't make a regression test for it. Very happy if you'd like me to pick that commit out, although I don't think it's doing any harm as it stands.