atlanhq / camelot

Camelot: PDF Table Extraction for Humans
https://camelot-py.readthedocs.io
Other
3.61k stars 349 forks source link

[MRG] Change import and usage according to pdfminer latest changes #430

Open xamey opened 3 years ago

xamey commented 3 years ago

Description

Camelot's dependency pdfminer has recently published a new version (20200720).

A minor change about a class name induces that camelot can't work anymore and fail every time.

Below, a screenshot of the error that is available in the trace :

image

Source

As visible in this diff, from version 20200517 to version 20200720, the class PDFTextExtractionNotAllowed has been renamed to PDFTextExtractionNotAllowedError.

Perhaps, as we can see here and here, camelot still uses the previous syntax.

Moreover, as camelot has defined it pdfminer dependency in its requirements.txt, it automatically updated to the latest pdfminer version.

Solution

To resolve this problem, we just have to change the class name used in camelot to the new one.