search

atlanta-ember-org / atlanta-ember-backend

0 stars 0 forks source link

Community resources #14

Closed ultimatemonty closed 8 years ago

ultimatemonty commented 8 years ago

Adds endpoints for community resources.

/cc @pdougall1 @camthompson @gschorkopf

gschorkopf commented 8 years ago

I might say that the commit history is a lil wonky. I'm going to review this based on file changes, but ideally the commits should tell a clear story chronologically.

ultimatemonty commented 8 years ago

@gschorkopf can atlanta-ember-backend/atlanta_ember_backend_development and atlanta-ember-backend/atlanta_ember_backend_test be removed/ignored? They're binaries and I'm sure wtf they do.

gschorkopf commented 8 years ago

If those are just your sqlite databases, then yeah.

gschorkopf commented 8 years ago

@ultimatemonty I'm going to take a stab at fixing this guy up. I'd like to get this in in good shape before tackling JSONAPI.org stuff

gschorkopf commented 8 years ago

The test suite won't run. Issue with uninitialized constant CommunityResourceController (NameError). The bug here is just naming: should be plural, CommunityResourcesController. But #17 would help us figure this out sooner.

Edit: Turns out either this branch (or develop/master) is failing.

gschorkopf commented 8 years ago

Tried to fix a few specs. But now I see that master is passing these; except for meetup_spec.rb :frowning:

ultimatemonty commented 8 years ago

@gschorkopf talked with @pdougall1 and @camthompson about this last night. Going to close this PR and not merge in favor of the Community Resources page being a easy way for folks to learn how to PR and contribute to a project. Thanks for all the feedback - it was good stuff!

I'll have a new PR later this week on the client that will add a note something to the effect of "Have a great resource you want to share? Submit a PR!"