atlanticwave-sdx / datamodel

Parsing and validation library for AtlanticWave SDX.
https://www.atlanticwave-sdx.net
MIT License
0 stars 1 forks source link

add the status/state back to port object #119

Closed YufengXin closed 5 months ago

YufengXin commented 5 months ago
  1. added the status and state fields back to port object init. The getter/setter are still there. (At one time last year, we thought these two should be filtered out in LC/OXP because they are for network management, not control purpose)

Note: @sajith It appeared the latest setup tools_scm requires the 'dev' tag has to be '.dev0'. See:

https://github.com/pypa/setuptools_scm/blob/main/src/setuptools_scm/_modify_version.py L21.

I had to do 'git tag -d 2.0.6.dev1' to remove the current tag in order to install.

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 8849964892

Details


Totals Coverage Status
Change from base Build 7910420627: 0.02%
Covered Lines: 1022
Relevant Lines: 1244

💛 - Coveralls
sajith commented 5 months ago

Note: @sajith It appeared the latest setup tools_scm requires the 'dev' tag has to be '.dev0'. See:

https://github.com/pypa/setuptools_scm/blob/main/src/setuptools_scm/_modify_version.py L21.

I had to do 'git tag -d 2.0.6.dev1' to remove the current tag in order to install.

@YufengXin Git tags should follow semantic versioning (major.minor.patch format), optionally followed by pre-release tags (.dev0, .dev1, .dev2... etc.)

The git tag 2.0.6.dev1 already exists, so we need to use 2.0.6.dev2.