atlanticwave-sdx / kytos-sdx-topology

0 stars 3 forks source link

self.get_kytos_topology() can result in a lot of IO here (when a higher frequency event is published) #15

Closed lmarinve closed 10 months ago

lmarinve commented 10 months ago

A GET topology is unnecessary here since the events are already driven from topology. Also, it's calling self.get_kytos_topology() again at the end of this handler and returning, but notice that a decorated @listen_to future result is discarded, so you actually won't get anything from that return, which another method is trying to call it; listen_to decorated handlers isn't meant to be called directly, so another extra request which the contents actually won't be used.

lmarinve commented 10 months ago

calling self.get_kytos_topology() removed