search

atlanticwave-sdx / kytos-sdx-topology

0 stars 3 forks source link

Add support for ISO3166 location field and adding inter-oxp links based on metadata #30

Closed italovalcy closed 3 months ago

italovalcy commented 3 months ago

Fixes #28 Fixes #29

Description of the change

  1. As requested by the sdx-meican development team, this PR adds support for exporting the ISO3166 fields based on configured metadata. In the future, we can see ways of automatically calculating those values based on lat/long, but for now, just relying on metadata is sufficient.
  2. Considering our last discussions on Inter-OXP links on slack and documented on Issue atlanticwave-sdx/sdx-controller#245, this will use the strategy of sending both the Port nni attribute along of the Link object for Inter-OXP links

Local tests

The changes suggested here will impact the validator. This will be handled separately on issue atlanticwave-sdx/sdx-continuous-development#102

lmarinve commented 3 months ago

Thank you for providing the code to implement the ISO3166 through the metadata.