atlanticwave-sdx / kytos-sdx

MIT License
0 stars 3 forks source link

fix: topology request during setup is blocking the MainThread, hanging until timeout #77

Closed viniarck closed 6 days ago

viniarck commented 1 week ago

Closes #75

Summary

Local Tests


2024-11-07 13:41:38,541 - INFO [kytos.core.controller] (MainThread) Loading NApp kytos/sdx
2024-11-07 13:41:38,542 - INFO [kytos.core.napps.base] (of_multi_table) Running NApp: <Main(of_multi_table, started 140441320150720)>
2024-11-07 13:41:38,555 - INFO [kytos.core.napps.base] (sdx) Running NApp: <Main(sdx, started 140441311758016)>
2024-11-07 13:41:38,556 - INFO [kytos.core.api_server] (MainThread) Started /api/kytos/sdx/topology/2.0.0 - GET
2024-11-07 13:41:38,556 - INFO [kytos.core.api_server] (MainThread) Started /api/kytos/sdx/topology/2.0.0 - POST
2024-11-07 13:41:38,557 - INFO [kytos.core.api_server] (MainThread) Started /api/kytos/sdx/l2vpn/1.0 - POST
2024-11-07 13:41:38,557 - INFO [kytos.core.api_server] (MainThread) Started /api/kytos/sdx/l2vpn/1.0/{service_id} - PATCH

kytos $> assert controller.napps[('kytos', 'sdx')]._topo_dict["links"]

kytos $> assert controller.napps[('kytos', 'sdx')]._converted_topo["links"]

kytos $> controller.napps[('kytos', 'sdx')].sdx_topology
Out[5]: 
{'_id': 'topology',
 'timestamp': '2024-11-07T16:41:43Z',
 'updated_at': datetime.datetime(2024, 11, 7, 16, 41, 43, 635379),
 'version': 3}

End-to-End Tests

N/A

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 11727522039

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
main.py 6 7 85.71%
<!-- Total: 6 7 85.71% -->
Files with Coverage Reduction New Missed Lines %
main.py 4 72.65%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 10990547959: -0.9%
Covered Lines: 486
Relevant Lines: 627

💛 - Coveralls