atlanticwave-sdx / sdx-controller

Central Controller for AtlanticWave SDX.
https://www.atlanticwave-sdx.net
MIT License
1 stars 3 forks source link

Clean up imports #185

Closed sajith closed 1 year ago

sajith commented 1 year ago

Issue is #184. These are the changes:

These were found by the ruff linter, and I am considering adding ruff checks as a CI step. Ruff reported some more errors, about which I will follow-up separately.

This PR also carries an unrelated change caused by coveralls triggering a goofy error: omit test modules from coverage measurement. It causes the coverage report to drop, but we will also get a more "honest" coverage report. I am planning on working on improving test coverage, so this would help.

coveralls commented 1 year ago

Coverage Status

coverage: 36.146% (-9.2%) from 45.352% when pulling 216f1c3d94b0e158dd5d60b6e4de7ea4eb2bae73 on 184.clean-up-imports into 81ac2adf0e98ba13702a53e9fe0a2b8ebe9c4e6e on main.