atlanticwave-sdx / sdx-controller

Central Controller for AtlanticWave SDX.
https://www.atlanticwave-sdx.net
MIT License
1 stars 3 forks source link

Handle connection deletions in PCE #225

Closed sajith closed 4 months ago

sajith commented 6 months ago

Resolves #224, but only somewhat (deletions are propagated to only PCE, not down to local controllers). I hope we can consider this an initial sketch.

These are the changes:

{
  "connection_id": "${connection_id}",
  "reason": "Connection published",
  "status": "OK"
}

Note that this response is not consistent with the API definition (and it wasn't consistent before too). Issue filed: #251.

This is stacked on top of #209 (because we need a handle to TEManager instance), which is in draft state right now. I will update this PR when #209 gets merged.

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 8756575986

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_controller/controllers/connection_controller.py 9 12 75.0%
<!-- Total: 9 12 75.0% -->
Totals Coverage Status
Change from base Build 8743534762: 0.03%
Covered Lines: 708
Relevant Lines: 1420

💛 - Coveralls