Closed italovalcy closed 5 months ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
sdx_controller/handlers/lc_message_handler.py | 0 | 1 | 0.0% | ||
<!-- | Total: | 4 | 5 | 80.0% | --> |
Totals | |
---|---|
Change from base Build 8715373036: | 0.002% |
Covered Lines: | 706 |
Relevant Lines: | 1417 |
@italovalcy Please run black?
Also I did not know that GitHub would do this:
Today I learned. :-)
I could not find documentation for this feature though.
@italovalcy Please run black?
Also I did not know that GitHub would do this:
Today I learned. :-)
I could not find documentation for this feature though.
Yeah, I think Italo created this branch off from the other branch. When that branch is merged to main, this branch will be auto rebase to main as well.
@italovalcy Please run black? Also I did not know that GitHub would do this: Today I learned. :-) I could not find documentation for this feature though.
Yeah, I think Italo created this branch off from the other branch. When that branch is merged to main, this branch will be auto rebase to main as well.
exactly! ;) this works very well for managing multiple PRs in parallel. Helps a lot
BTW, could you please give another review, @sajith ? I missed the black warning.
Heads up: this PR sits on top of #254
Similar to https://github.com/atlanticwave-sdx/sdx-lc/pull/114
OXP's domain name might be something like amlight.net or zaoxi.ac.nz. So this updates to use the full domain name instead of splitting to get the domain name.