atlanticwave-sdx / sdx-controller

Central Controller for AtlanticWave SDX.
https://www.atlanticwave-sdx.net
MIT License
1 stars 3 forks source link

Update OXP domain name according to the new standard on SDX-LC #255

Closed italovalcy closed 5 months ago

italovalcy commented 5 months ago

Heads up: this PR sits on top of #254

Similar to https://github.com/atlanticwave-sdx/sdx-lc/pull/114

OXP's domain name might be something like amlight.net or zaoxi.ac.nz. So this updates to use the full domain name instead of splitting to get the domain name.

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 8741551705

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_controller/handlers/lc_message_handler.py 0 1 0.0%
<!-- Total: 4 5 80.0% -->
Totals Coverage Status
Change from base Build 8715373036: 0.002%
Covered Lines: 706
Relevant Lines: 1417

💛 - Coveralls
sajith commented 5 months ago

@italovalcy Please run black?

Also I did not know that GitHub would do this:

image

Today I learned. :-)

I could not find documentation for this feature though.

congwang09 commented 5 months ago

@italovalcy Please run black?

Also I did not know that GitHub would do this:

image

Today I learned. :-)

I could not find documentation for this feature though.

Yeah, I think Italo created this branch off from the other branch. When that branch is merged to main, this branch will be auto rebase to main as well.

italovalcy commented 5 months ago

@italovalcy Please run black? Also I did not know that GitHub would do this: image Today I learned. :-) I could not find documentation for this feature though.

Yeah, I think Italo created this branch off from the other branch. When that branch is merged to main, this branch will be auto rebase to main as well.

exactly! ;) this works very well for managing multiple PRs in parallel. Helps a lot

BTW, could you please give another review, @sajith ? I missed the black warning.