Closed congwang09 closed 3 months ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
sdx_controller/handlers/connection_handler.py | 0 | 1 | 0.0% | ||
sdx_controller/controllers/connection_controller.py | 7 | 10 | 70.0% | ||
<!-- | Total: | 7 | 11 | 63.64% | --> |
Totals | |
---|---|
Change from base Build 8664224346: | 50.9% |
Covered Lines: | 708 |
Relevant Lines: | 1421 |
When no 'id' in body, should the newly generated 'id' be also added to the body?
Sure. Added that. Actually id is a required field enforced by swagger, so this probably is not very useful anyway.
it's good that you catch it, maybe also adding a log somewhere earlier.
Looks like I can't review it again? @sajith pls review/approve.
Resolves: https://github.com/atlanticwave-sdx/sdx-controller/issues/256
Use connection ID instead of hard coded db key name.
Also if we cannot generate a graph, it should not be 400, because it's not due to bad request. Would 500 make sense?