search

atlanticwave-sdx / sdx-controller

Central Controller for AtlanticWave SDX.
https://www.atlanticwave-sdx.net
MIT License
1 stars 3 forks source link

Delete connection #288

Closed congwang09 closed 1 month ago

congwang09 commented 1 month ago

Resolves: https://github.com/atlanticwave-sdx/sdx-controller/issues/261

Enable sdx-controller to delete connection.

YufengXin commented 1 month ago

the TOX (readme) that Sajith did is probably the easiest way for testing/debugging.

congwang09 commented 1 month ago

the TOX (readme) that Sajith did is probably the easiest way for testing/debugging.

There are other code checks besides tests. We should probablly enable build per commit, so we can put up PR when the code is really ready for review. I'll look into this.

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9487507499

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_controller/controllers/connection_controller.py 4 5 80.0%
sdx_controller/handlers/connection_handler.py 14 17 82.35%
<!-- Total: 19 23 82.61% -->
Files with Coverage Reduction New Missed Lines %
sdx_controller/utils/db_utils.py 1 93.94%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 9482700199: 0.09%
Covered Lines: 748
Relevant Lines: 1456
💛 - Coveralls
YufengXin commented 1 month ago

@congwang09 looks like you need to rebase with 'main'

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9488709149

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_controller/controllers/connection_controller.py 4 5 80.0%
sdx_controller/handlers/connection_handler.py 14 17 82.35%
<!-- Total: 19 23 82.61% -->
Files with Coverage Reduction New Missed Lines %
sdx_controller/utils/db_utils.py 1 93.94%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 9487554018: 0.09%
Covered Lines: 748
Relevant Lines: 1456
💛 - Coveralls