atlanticwave-sdx / sdx-controller

Central Controller for AtlanticWave SDX.
https://www.atlanticwave-sdx.net
MIT License
1 stars 3 forks source link

Enable check and test for all branches #290

Closed congwang09 closed 1 month ago

congwang09 commented 1 month ago

Enable check and test for all branches and all commits.

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9500799262

Details


Totals Coverage Status
Change from base Build 9500593558: 0.0%
Covered Lines: 748
Relevant Lines: 1456

💛 - Coveralls
congwang09 commented 1 month ago

Before this change, github actions only run code checks and tests after the PR is created. This change lets us see failed tests before the PR is created.

Screenshot 2024-06-13 at 10 15 47 AM

After the change the checks run on every commit:

Screenshot 2024-06-13 at 10 18 47 AM
sajith commented 1 month ago

Ah, so you want to run tests against every commit. The trouble with that is, we only get a limited amount of free CI time (3000 minutes per month, across all repositories in the organization) on GitHub's infrastructure. We will quickly run out of that resource if we run tests against every commit.

It is good enough that main branch passes tests, and code that we merge into the main branch passes tests.

congwang09 commented 1 month ago

Ah, so you want to run tests against every commit. The trouble with that is, we only get a limited number of free CI time (3000 minutes per month) on GitHub's infrastructure. We will quickly run out of that resource if we run tests against every commit.

It is good enough that main branch passes tests, and code that we merge into the main branch passes tests.

Oh I see. that makes sense. I'll close this PR.