atlanticwave-sdx / sdx-controller

Central Controller for AtlanticWave SDX.
https://www.atlanticwave-sdx.net
MIT License
1 stars 3 forks source link

Use correct `env` file format #294

Closed sajith closed 3 weeks ago

sajith commented 3 weeks ago

In the README, we say this: "To run sdx-controller alone... $ docker run -p 8080:8080 sdx-controller --env-file=.env"

This will result in an error, because the --env-file argument is being passed to the container:

unknown option --env-file=.env
usage: python3 [option] ... [-c cmd | -m mod | file | -] [arg] ...
Try `python -h' for more information.

The actual command should be docker run --env-file=.env -p 8080:8080 sdx-controller, but that also will not work with our current example env.template format:

docker: poorly formatted environment: variable 'export SDX_HOST' contains whitespaces.
See 'docker run --help'.

All those export invocations are the problem. They are not needed according to Docker docs on env file syntax. unnecessary -- source-ing them will work without export.