atlanticwave-sdx / sdx-controller

Central Controller for AtlanticWave SDX.
https://www.atlanticwave-sdx.net
MIT License
1 stars 3 forks source link

Use MONGODB_CONNSTRING when MONGO_HOST is not set #300

Closed italovalcy closed 1 month ago

italovalcy commented 1 month ago

Similar to https://github.com/atlanticwave-sdx/sdx-lc/pull/154 (Issue https://github.com/atlanticwave-sdx/sdx-lc/issues/153)

When MONGO_HOST is not set, try to use MONGODB_CONNSTRING (basically falls back to the old method of specifying the MongoDB URI), and fail when neither is set.

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 10077796092

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_controller/utils/db_utils.py 8 12 66.67%
<!-- Total: 8 12 66.67% -->
Totals Coverage Status
Change from base Build 9876876115: -0.009%
Covered Lines: 767
Relevant Lines: 1484

💛 - Coveralls
YufengXin commented 1 month ago

@congwang09 @italovalcy Could you ls run black to pass the code check so this can be merged.

italovalcy commented 1 month ago

@congwang09 @italovalcy Could you ls run black to pass the code check so this can be merged.

Hi @YufengXin sorry for the delay. I fixed that a few days ago but I forgot to push! rss sorry about that