Housekeeping updates - Githubissues

atlanticwave-sdx / sdx-controller

Central Controller for AtlanticWave SDX.

https://www.atlanticwave-sdx.net

MIT License

1 stars 3 forks source link

Housekeeping updates #321

Closed sajith closed 3 weeks ago

sajith commented 3 weeks ago

Addresses the test breakage in https://github.com/atlanticwave-sdx/sdx-controller/pull/319, and some other things:

Use flit as the build backend for sdx-controller, similar to https://github.com/atlanticwave-sdx/datamodel/pull/146 and https://github.com/atlanticwave-sdx/pce/pull/216.
Drop Python 3.8 from test matrix, and add Python 3.12 to test matrix.
Add Italo to author's list.
Add a .mailmap file so that git log etc will print the correct thing.
Update Dockerfile and hadolint check now that we're not using setuptools_scm anymore.
Use pce@3.0.0.dev0 as the dependency, not pce@main.

coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 10493583864

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 58.211%

Totals
Change from base Build 10473608051:	0.3%
Covered Lines:	1038
Relevant Lines:	1847

💛 - Coveralls

congwang09 commented 3 weeks ago

why so many email for Cong in .mailmap?

Yeah true. Some of my laptops have different hostnames when moving around different networks. Also I committed some changes from the sdx RENCI testbed VM. But those are not real email addresses. Only @renci.org one is the right email address. @sajith should we only keep the email address?

sajith commented 3 weeks ago

The .mailmap is there so that git log and git shortlog will show Cong Wang <cwang@renci.org> instead of C <cong@Cs-MacBook-Air.attlocal.net> etc. Since we can't rewrite git history, I think this is helpful.