atlanticwave-sdx / sdx-controller

Central Controller for AtlanticWave SDX.
https://www.atlanticwave-sdx.net
MIT License
2 stars 3 forks source link

Implement PATCH connection #324

Closed congwang09 closed 3 months ago

congwang09 commented 3 months ago

Resolves: https://github.com/atlanticwave-sdx/sdx-controller/issues/235

Implement PATCH endpoint. And replaced connection_id with service_id, for consistency.

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 10638427574

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_controller/handlers/connection_handler.py 8 10 80.0%
sdx_controller/controllers/l2vpn_controller.py 14 35 40.0%
<!-- Total: 22 45 48.89% -->
Totals Coverage Status
Change from base Build 10569856636: -0.4%
Covered Lines: 1040
Relevant Lines: 1868

💛 - Coveralls
congwang09 commented 3 months ago

Note: patch -> delete then reprovisioning.

The new connection will be given a new service_id?

Yes, it'll have a new service_id, since we delete the old connection, and we keep the old connection in DB, just mark it as "deleted". There'll be conflict if we keep the same service_id.