atlanticwave-sdx / sdx-controller

Central Controller for AtlanticWave SDX.
https://www.atlanticwave-sdx.net
MIT License
2 stars 3 forks source link

Handle out-of-range VLANs gracefully #357

Closed sajith closed 2 weeks ago

sajith commented 2 weeks ago

Resolves #356.

coveralls commented 2 weeks ago

Pull Request Test Coverage Report for Build 11859274966

Details


Totals Coverage Status
Change from base Build 11799592589: 0.1%
Covered Lines: 1109
Relevant Lines: 1948

💛 - Coveralls
sajith commented 2 weeks ago

@italovalcy The request you've provided in #356 is this:

{
  "name": "VLAN between AMPATH/300 and TENET/300",
  "endpoints": [
    {
      "port_id": "urn:sdx:port:ampath.net:Ampath3:50",
      "vlan": "300"
    },
    {
      "port_id": "urn:sdx:port:tenet.ac.za:Tenet03:50",
      "vlan": "any"
    }
  ]
}

But that does not produce an out of range error (see test status at commit c0389de), so I used 30000 for endpoints.0.vlan instead. The error you reported should be fixed once this PR gets merged. Thank you for the helpful error description!