search

atlanticwave-sdx / sdx-controller

Central Controller for AtlanticWave SDX.
https://www.atlanticwave-sdx.net
MIT License
2 stars 3 forks source link

Make tests more usable #94

Closed sajith closed 1 year ago

sajith commented 1 year ago

This should address #25 and #28.

Here's a summary of what is being done in this PR:

  1. Skips test_place_connection(). Making it work will have to be a separate PR. #102 should track this.
  2. Adds a TopicQueProducer.stop_keep_alive() method which will stop the keep-alive thread in that class.
  3. The global table of per-domain TopicQueueProducer instances are localized, and call stop_keep_alive() once the message is published. With this, the test suite can exit once all the tests are finished running.
  4. Corrects some typos in OpenAPI definitions and API calls.
  5. Updates dependencies.
  6. Drops nosetests (which is unmaintained and doesn't work with new Python 3.x releases) in favor of pytest.
  7. Adds the necessary environment variables to tox.ini
  8. Starts a RabbitMQ service in CI so that tests can be run.
sajith commented 1 year ago

the PR notes can be part of the document-:)

Which document though? Some changes are temporary work-arounds, some are housekeeping, and some are probably worth noting somewhere. I am not sure what to document and where because we don't have a changelog yet...