SDX-LC should be aware of the internal circuit ID created by OXP

[italovalcy]

When we are creating breakdown connections from the SDX-LC to the OXPO we send information like the name, uni_an and uni_z. As a result of the creation process, we dont save any results from the OXPs. To make things simple for later removal of the same circuit, it would be nice if the SDX-LC saves the OXP's circuit_id to then asks for removal later on using the same ID.

Another approach would be: the OXP's SDX Napp could be responsible for storing the internal OXPs circuit_id and then it will be providing a mapping between the same data provided when creating a breakdown connection to use it for removal later on.

I'm creating this issue here so we can discuss what would be the best strategy.

[YufengXin]

related to #104 #105 also related to provisioning failure handling: ie, if an OXP provisioning system failed to provision its breakdown and returns a failure message, LC needs to inform sdx-controller who will roll back the connection.

[italovalcy]

Hi team,

I'm reviewing this topic here and I think we should not keep track of the OXPs internal connection ID. Another approach would be submitting the same connection body from creation to the deletion. That way we leave to the OXP to figure out the correct ID. Since no two circuits will share the exact same attributes (UNI_A, UNI_Z), we can then guarantee uniqueness.

Furthermore, for changing an existing connection, the approach would be deleting the old one and create a new one.

Please let me know what you guys think.

Cc'ing @YufengXin @congwang09 and @sajith

[congwang09]

Hi team,

I'm reviewing this topic here and I think we should not keep track of the OXPs internal connection ID. Another approach would be submitting the same connection body from creation to the deletion. That way we leave to the OXP to figure out the correct ID. Since no two circuits will share the exact same attributes (UNI_A, UNI_Z), we can then guarantee uniqueness.

Furthermore, for changing an existing connection, the approach would be deleting the old one and create a new one.

Please let me know what you guys think.

Cc'ing @YufengXin @congwang09 and @sajith

Hmm... without a unique identifier, if user wants to GET connection, how can we figure out which connection the user (e.g., MEICAN) wants to get?

[italovalcy]

Hi @congwang09 and @YufengXin, considering our discussion in today's meeting, I believe we can close this issue. As long as the SDX-LC provides the same request body as when creating (now with the DELETE method instead of POST), the removal can be handled fine by OXPO. I even believe that this is better because it keeps things clean (sdx-lc does not need to get involved into internal details of the OXPO, like the internal circuit ID)