search

atlarge-research / opencraft

Other
4 stars 2 forks source link

Changed checkstyle to our preferences and added guidelines for coding - [merged] #118

Closed jdonkervliet closed 4 years ago

jdonkervliet commented 4 years ago

In GitLab by @wubero on May 5, 2020, 11:39

Merges feature/checkstyle -> development

We adjusted the checkstyle.xml file to suit the rules we discussed and created a guidlines file in de etc folder where some rules are specified with code examples.

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 5, 2020, 13:25

Commented on etc/checkstyle.xml line 187

Removing the escape before the . would allow any character to be used, and removing the *'s prevents more than one character from the group being used.

It should probably be something like: ^[a-z][a-z0-9]*(\.[a-z][a-z0-9]*)*$.

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 5, 2020, 13:30

Commented on etc/checkstyle.xml line 231

The () were removed from the previous few regular expressions, should they be removed here as well? Or should they be added back in to those previous ones?

jdonkervliet commented 4 years ago

In GitLab by @wubero on May 5, 2020, 14:22

Commented on etc/checkstyle.xml line 187

changed this line in version 2 of the diff

jdonkervliet commented 4 years ago

In GitLab by @wubero on May 5, 2020, 14:22

added 1 commit

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 5, 2020, 14:43

resolved all threads

jdonkervliet commented 4 years ago

In GitLab by @wubero on May 5, 2020, 14:57

added 1 commit

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 5, 2020, 14:58

changed title from Changed checkstyle to our preferences and added guidlines for coding to Changed checkstyle to our preferences and added guid{+e+}lines for coding

jdonkervliet commented 4 years ago

In GitLab by @wubero on May 5, 2020, 15:04

added 8 commits

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 5, 2020, 15:08

enabled an automatic merge when the pipeline for 4b58799fcfed0460beb9bd3f42d8edaff8908040 succeeds

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 5, 2020, 15:08

canceled the automatic merge

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 5, 2020, 15:08

enabled an automatic merge when the pipeline for 4b58799fcfed0460beb9bd3f42d8edaff8908040 succeeds

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 5, 2020, 15:16

merged

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 5, 2020, 15:16

mentioned in commit 20870c1d782075bec77967602187df94a721dc5a