atlarge-research / opencraft

Other
5 stars 2 forks source link

Concurrent broker implementation - [merged] #121

Closed jdonkervliet closed 4 years ago

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 6, 2020, 11:25

Merges feature/simple-broker-implementation -> development

jdonkervliet commented 4 years ago

In GitLab by @JimVliet on May 6, 2020, 11:30

Commented on src/main/java/net/glowstone/messaging/concurrent/ConcurrentBroker.java line 10

 * hash map allows multiple publishers and subscribers to access the broker simultaneously.
jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 6, 2020, 11:30

resolved all threads

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 6, 2020, 11:30

Commented on src/main/java/net/glowstone/messaging/concurrent/ConcurrentBroker.java line 10

changed this line in version 2 of the diff

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 6, 2020, 11:30

added 1 commit

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @JimVliet on May 6, 2020, 11:31

Commented on src/main/java/net/glowstone/messaging/concurrent/ConcurrentChannel.java line 9

 * hash map allows multiple publishers and subscribers to access the broker simultaneously.
jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 6, 2020, 11:31

Commented on src/main/java/net/glowstone/messaging/concurrent/ConcurrentBroker.java line 45

            return channel.isEmtpy() ? null : channel;
jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 6, 2020, 11:32

Commented on src/main/java/net/glowstone/messaging/concurrent/ConcurrentBroker.java line 45

And then remove the top part, but this is more of a stylistic choice

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 6, 2020, 11:32

Commented on src/main/java/net/glowstone/messaging/concurrent/ConcurrentChannel.java line 9

changed this line in version 3 of the diff

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 6, 2020, 11:32

Commented on src/main/java/net/glowstone/messaging/concurrent/ConcurrentChannel.java line 9

changed this line in version 3 of the diff

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 6, 2020, 11:32

added 1 commit

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 6, 2020, 11:39

resolved all threads

jdonkervliet commented 4 years ago

In GitLab by @larsdetombe on May 6, 2020, 11:42

enabled an automatic merge when the pipeline for 6cf1445482e10553a1b11d2e4d37ec06e82dda24 succeeds

jdonkervliet commented 4 years ago

In GitLab by @larsdetombe on May 6, 2020, 11:48

mentioned in commit 4b8d214ad77562787f53f2dde0997f8c724a72af