Optimise Continuous Integration - [merged]

[jdonkervliet]

In GitLab by @julian9499 on May 7, 2020, 11:33

Merges feature/optimise-ci -> development

Optimise the ci to only compile the project once solves #27

[jdonkervliet]

In GitLab by @julian9499 on May 7, 2020, 11:47

added 1 commit

• 02265cb3 - remove target folder from cache and put in the artifacts instead

Compare with previous version

[jdonkervliet]

In GitLab by @julian9499 on May 7, 2020, 11:53

added 1 commit

• bff418e0 - add dependencies to build job for other jobs

Compare with previous version

[jdonkervliet]

In GitLab by @julian9499 on May 7, 2020, 11:55

added 1 commit

• 41901117 - fix syntax error in yaml array

Compare with previous version

[jdonkervliet]

In GitLab by @julian9499 on May 7, 2020, 12:16

added 1 commit

• ff3215a6 - Apply hotfix to known compiler plugin bug where it would not recognize up to...

Compare with previous version

[jdonkervliet]

In GitLab by @swabbur on May 7, 2020, 13:48

changed title from {-Feature/optimise ci-} to {+Optimise Continuous Integration+}

[jdonkervliet]

In GitLab by @swabbur on May 7, 2020, 13:59

Commented on pom.xml line 354

Why not? Incremental compilation seems like something that would help tremendously when compiling.

[jdonkervliet]

In GitLab by @swabbur on May 7, 2020, 14:00

Commented on .gitlab-ci.yml line 27

1 week seems very arbitrary. Do we even need it to expire?

[jdonkervliet]

In GitLab by @swabbur on May 7, 2020, 14:01

Commented on .gitlab-ci.yml line 24

Shouldn't the artifacts be listed where the cache is listed as well?

[jdonkervliet]

In GitLab by @swabbur on May 7, 2020, 14:01

Commented on .gitlab-ci.yml line 30

I was thinking we might as well remove the deployment. I was expecting to be able to add it soon, but it seems to take longer at (other) Jim's end.

[jdonkervliet]

In GitLab by @julian9499 on May 7, 2020, 14:16

changed the description

[jdonkervliet]

In GitLab by @julian9499 on May 7, 2020, 14:19

Commented on pom.xml line 354

The plugin has a bug where it would recompile all the class files even though the source files where not updated after the last compilation. This is the way to "hotfix" this issue

[jdonkervliet]

In GitLab by @julian9499 on May 7, 2020, 14:20

Commented on .gitlab-ci.yml line 27

It is normally 1 month, but I honestly do now know how big this server is and did not want to risk it.

[jdonkervliet]

In GitLab by @julian9499 on May 7, 2020, 14:21

Commented on .gitlab-ci.yml line 24

Artifacts are job specific and thus cannot be listed in a higher level https://docs.gitlab.com/ee/ci/caching/

[jdonkervliet]

In GitLab by @julian9499 on May 7, 2020, 14:26

Commented on .gitlab-ci.yml line 30

While it is still manual so I would say we can keep it and make an issue out of it.

[jdonkervliet]

In GitLab by @larsdetombe on May 7, 2020, 17:11

Commented on .gitlab-ci.yml line 27

But is it necessary? Because if it isn't it might simply be better to just not let it expire

[jdonkervliet]

In GitLab by @julian9499 on May 7, 2020, 17:40

Commented on .gitlab-ci.yml line 27

changed this line in version 6 of the diff

[jdonkervliet]

In GitLab by @julian9499 on May 7, 2020, 17:40

added 1 commit

• 96634d36 - change artifact expiry to 1 hour

Compare with previous version

[jdonkervliet]

In GitLab by @swabbur on May 7, 2020, 17:41

resolved all threads

[jdonkervliet]

In GitLab by @larsdetombe on May 7, 2020, 17:42

Commented on .gitlab-ci.yml line 27

Because we don't need to keep the artifact, an hour seems better indeed.

[jdonkervliet]

In GitLab by @swabbur on May 7, 2020, 17:43

enabled an automatic merge when the pipeline for 96634d366f31c4ff66db402797afc149cf6874cf succeeds

[jdonkervliet]

In GitLab by @swabbur on May 7, 2020, 17:50

merged

[jdonkervliet]

In GitLab by @swabbur on May 7, 2020, 17:50

mentioned in commit 38bdf721dcec1a120f950b51ddce7e8bb5e51a1c