search

atlarge-research / opencraft

Other
4 stars 2 forks source link

Move Main into seperate class - [merged] #126

Closed jdonkervliet closed 4 years ago

jdonkervliet commented 4 years ago

In GitLab by @wubero on May 8, 2020, 11:04

Merges feature/main-move -> development

This branch solves issue #9 , moved the main into a seperate Main class and fixed some checkstyle errors

jdonkervliet commented 4 years ago

In GitLab by @wubero on May 8, 2020, 11:08

changed title from {-Feature/main move-} to {+Move Main into seperate class+}

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 8, 2020, 11:10

Commented on src/main/java/net/glowstone/dispenser/DefaultDispenseBehavior.java line 20

I actually prefer the prior one. If this is something CheckStyle enforces, it should be changed.

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 8, 2020, 11:10

Commented on src/main/java/net/glowstone/entity/EntityManager.java line 9

We might want to look into allowing these additional whitelines, don't you think?

jdonkervliet commented 4 years ago

In GitLab by @wubero on May 8, 2020, 12:35

added 3 commits

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @wubero on May 8, 2020, 12:45

Commented on src/main/java/net/glowstone/dispenser/DefaultDispenseBehavior.java line 20

changed this line in version 3 of the diff

jdonkervliet commented 4 years ago

In GitLab by @wubero on May 8, 2020, 12:45

added 1 commit

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 8, 2020, 12:51

resolved all threads

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 8, 2020, 12:51

enabled an automatic merge when the pipeline for fba841616bb82ce426d41b567f1fd0038a7d53fb succeeds

jdonkervliet commented 4 years ago

In GitLab by @wubero on May 8, 2020, 12:51

Commented on src/main/java/net/glowstone/dispenser/DefaultDispenseBehavior.java line 20

This is solved

jdonkervliet commented 4 years ago

In GitLab by @wubero on May 8, 2020, 12:51

resolved all threads

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 8, 2020, 12:53

merged

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 8, 2020, 12:53

mentioned in commit 4f84a90f4554e44bf2ce79355261443f3a78e058