search

atlarge-research / opencraft

Other
4 stars 2 forks source link

Add check as first stage and gitlab coverage reporting - [merged] #127

Closed jdonkervliet closed 4 years ago

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 8, 2020, 11:55

Merges feature/update-continues-integration -> development

Add checkstyle as first stage and include jacoco test reporting

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 8, 2020, 12:09

added 1 commit

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 8, 2020, 12:11

changed title from {-a-}dd check as first stage and gitlab coverage reporting to {+A+}dd check as first stage and gitlab coverage reporting

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 8, 2020, 12:12

Commented on .gitlab-ci.yml line 36

Why rename it to verify if the action was changed to test?

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 8, 2020, 12:15

Commented on .gitlab-ci.yml line 46

Could you add the JaCoco report? It can be used to display the coverage on the ReadMe.

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 8, 2020, 12:19

Commented on .gitlab-ci.yml line 16

Why not make these separate stages?

(Also, consider naming is static analysis, in case we add plugins like FindBugs in the future)

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 8, 2020, 12:20

Commented on .gitlab-ci.yml line 26

Do we have to pass all of the files in target? Or could it be reduced?

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 8, 2020, 12:27

Commented on .gitlab-ci.yml line 16

Separate stages are not parallelizable and since the linting does not depend on the build I thought it would be great to improve performance

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 8, 2020, 12:54

Commented on .gitlab-ci.yml line 16

changed this line in version 3 of the diff

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 8, 2020, 12:54

added 5 commits

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 8, 2020, 12:55

Commented on .gitlab-ci.yml line 36

changed this line in version 4 of the diff

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 8, 2020, 12:55

added 1 commit

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 8, 2020, 13:08

Commented on .gitlab-ci.yml line 36

fixed

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 8, 2020, 13:11

Commented on .gitlab-ci.yml line 16

Separated them

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 8, 2020, 13:12

Commented on .gitlab-ci.yml line 46

I added it to the public path and thus it can be viewed on the gitlab pages url if enabled, but for that I have to ask jesse

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 8, 2020, 13:26

resolved all threads

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 8, 2020, 13:26

resolved all threads

jdonkervliet commented 4 years ago

In GitLab by @larsdetombe on May 8, 2020, 13:53

merged

jdonkervliet commented 4 years ago

In GitLab by @larsdetombe on May 8, 2020, 13:53

mentioned in commit 5bd61807b5e7c59d464ccaef4d581ae85fd4cc89