search

atlarge-research / opencraft

Other
5 stars 2 forks source link

CheckStyle import order - [closed] #130

Closed jdonkervliet closed 4 years ago

jdonkervliet commented 4 years ago

In GitLab by @wubero on May 9, 2020, 15:13

Merges feature/checkstyle-import-order -> development

Include a whileline after importgroup and fix remaining checkstyle issues. We also now allow star imports because some classes import 35 methods from other classes which makes it better to use the star import.

jdonkervliet commented 4 years ago

In GitLab by @wubero on May 9, 2020, 15:18

added 17 commits

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 9, 2020, 15:46

changed title from {-checks-}tyle import order to {+CheckS+}tyle import order

jdonkervliet commented 4 years ago

In GitLab by @JimVliet on May 11, 2020, 01:24

Commented on src/main/java/net/glowstone/GlowOfflinePlayer.java line 64

To be honest, I do not like this alignment. I would prefer the chopped off version:

public static CompletableFuture<GlowOfflinePlayer> getOfflinePlayer(
    GlowServer server,
    UUID uuid
) {
    ...
}
jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 11, 2020, 10:05

Commented on src/main/java/net/glowstone/GlowOfflinePlayer.java line 64

I agree, chopped off looks better here.

jdonkervliet commented 4 years ago

In GitLab by @wubero on May 11, 2020, 10:11

closed

jdonkervliet commented 4 years ago

In GitLab by @wubero on May 11, 2020, 10:12

A new mr will be opened