search

atlarge-research / opencraft

Other
4 stars 2 forks source link

Move block updating from GlowPlayer to GlowWorld - [merged] #133

Closed jdonkervliet closed 4 years ago

jdonkervliet commented 4 years ago

In GitLab by @larsdetombe on May 11, 2020, 14:49

Merges feature/move-block-updates -> development

This merge request corresponds to the issue #7

Moved functionaility of blockupdates in the processBlockUpdates function in GlowPlayer to GlowWorld to support the publishing of messages.

jdonkervliet commented 4 years ago

In GitLab by @wubero on May 11, 2020, 15:12

Commented on src/main/java/net/glowstone/GlowWorld.java line 422

Shouldn't this be initialized in the constructor?

jdonkervliet commented 4 years ago

In GitLab by @wubero on May 11, 2020, 15:13

Commented on src/main/java/net/glowstone/GlowWorld.java line 437

Are we going to javadoc fields? If not we should remove this.

jdonkervliet commented 4 years ago

In GitLab by @larsdetombe on May 11, 2020, 15:24

Commented on src/main/java/net/glowstone/GlowWorld.java line 422

This is still from the old code, I can move all the other variables as well I guess

jdonkervliet commented 4 years ago

In GitLab by @larsdetombe on May 11, 2020, 15:28

Commented on src/main/java/net/glowstone/GlowWorld.java line 437

This was also from the old implementation, but I agree it is better to remove it

jdonkervliet commented 4 years ago

In GitLab by @larsdetombe on May 11, 2020, 15:38

Commented on src/main/java/net/glowstone/GlowWorld.java line 422

changed this line in version 2 of the diff

jdonkervliet commented 4 years ago

In GitLab by @larsdetombe on May 11, 2020, 15:38

Commented on src/main/java/net/glowstone/GlowWorld.java line 437

changed this line in version 2 of the diff

jdonkervliet commented 4 years ago

In GitLab by @larsdetombe on May 11, 2020, 15:38

added 1 commit

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @larsdetombe on May 11, 2020, 15:38

resolved all threads

jdonkervliet commented 4 years ago

In GitLab by @JimVliet on May 11, 2020, 20:26

Commented on src/main/java/net/glowstone/GlowWorld.java line 746

Should be 'a message'

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 12, 2020, 09:32

Commented on src/main/java/net/glowstone/GlowWorld.java line 746

changed this line in version 3 of the diff

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 12, 2020, 09:32

added 1 commit

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 12, 2020, 09:33

Commented on src/main/java/net/glowstone/GlowWorld.java line 746

I've updated the JavaDoc to correct its spelling.

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 12, 2020, 09:33

resolved all threads

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 12, 2020, 09:33

enabled an automatic merge when the pipeline for 43d0054463d4504d9627fccf03e2c360b5681d15 succeeds

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 12, 2020, 09:41

merged

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 12, 2020, 09:41

mentioned in commit 6ae4246ea87d118c7ea2a74947ea8eb2be34a6fe