search

atlarge-research / opencraft

Other
5 stars 2 forks source link

Send block changes directly from source - [merged] #137

Closed jdonkervliet closed 4 years ago

jdonkervliet commented 4 years ago

In GitLab by @larsdetombe on May 13, 2020, 14:27

Merges feature/direct-block-change -> development

Fix #47

Messages that were from an entity to the world via the player are now send directly to world.
Some broadcast messages are not duplicated anymore and only broadcasted once to the player.
It can still be possible that some block changes are duplicated, however this has been reduced.
The block break animation is still send from the player, because the player is in this case the source of the message.

jdonkervliet commented 4 years ago

In GitLab by @larsdetombe on May 13, 2020, 14:29

added 1 commit

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @JimVliet on May 13, 2020, 16:07

changed the description

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 13, 2020, 18:12

Commented on src/main/java/net/glowstone/block/entity/BannerEntity.java line 57

Could you add a TODO to changes like these to indicate that they may broadcast messages multiple times? Or redirect them in such a way that we can easily fix these duplicated messages once we have altered the Broker/MessagingSystem?

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 13, 2020, 18:14

Commented on src/main/java/net/glowstone/util/DeprecatedMethodException.java line 9

Do we need this constructor? And if we do, could you fix the curly-brackets such that they are on the same line?

jdonkervliet commented 4 years ago

In GitLab by @larsdetombe on May 13, 2020, 18:40

Commented on src/main/java/net/glowstone/block/entity/BannerEntity.java line 57

I will add todos, I believe this happens in 4 classes in total.

jdonkervliet commented 4 years ago

In GitLab by @larsdetombe on May 13, 2020, 18:42

Commented on src/main/java/net/glowstone/util/DeprecatedMethodException.java line 9

I guess we do not need this constructor, but in the case that in the future we want to use this exception more often it might be useful to be able to just create the DeprecatedMethodException without specifying a message. But it is not used right now so I could delete it.

jdonkervliet commented 4 years ago

In GitLab by @larsdetombe on May 13, 2020, 18:51

Commented on src/main/java/net/glowstone/util/DeprecatedMethodException.java line 9

changed this line in version 3 of the diff

jdonkervliet commented 4 years ago

In GitLab by @larsdetombe on May 13, 2020, 18:51

added 1 commit

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @larsdetombe on May 13, 2020, 19:01

resolved all threads

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 14, 2020, 09:44

merged

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 14, 2020, 09:44

mentioned in commit 4e1437994c68551c9228c89e178cfe33589870ee