atlarge-research / opencraft

Other
4 stars 2 forks source link

Fix NullPointerException when creating new world - [merged] #140

Closed jdonkervliet closed 4 years ago

jdonkervliet commented 4 years ago

In GitLab by @larsdetombe on May 15, 2020, 16:54

Merges feature/fix-nullpointer -> development

Fix #59

Broadcasting without a check causes null pointer exceptions when creating a new world, this has (mostly) been changed back to the old implementation.

jdonkervliet commented 4 years ago

In GitLab by @larsdetombe on May 15, 2020, 16:55

changed the description

jdonkervliet commented 4 years ago

In GitLab by @larsdetombe on May 15, 2020, 16:56

changed title from Fix {-n-}ullPointerException when creating new world to Fix {+N+}ullPointerException when creating new world

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 15, 2020, 16:57

Commented on src/main/java/net/glowstone/GlowWorld.java line 938

Streams should be chopped down to multiple lines.

jdonkervliet commented 4 years ago

In GitLab by @larsdetombe on May 15, 2020, 16:58

added 1 commit

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @larsdetombe on May 15, 2020, 16:59

resolved all threads

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 15, 2020, 16:59

resolved all threads

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 15, 2020, 16:59

enabled an automatic merge when the pipeline for e1b6a8d093f0d331e259ee963692ee0ee0321dcc succeeds

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 15, 2020, 17:09

merged

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 15, 2020, 17:09

mentioned in commit f3a95d37f9140aad94901b334e6468b793220ccc