Mesa biome bugfix - [merged] #141

Closed jdonkervliet closed 4 years ago

In GitLab by @wubero on May 18, 2020, 12:33

Merges bugfix/mesa-biome -> development

This merge request closes issue #44 fix the bug in the mesa biome generation.

In GitLab by @wubero on May 18, 2020, 12:33

changed the description

In GitLab by @wubero on May 18, 2020, 12:37

added 1 commit

7045c8d9 - Fix checkstyle issue

Compare with previous version

In GitLab by @JimVliet on May 18, 2020, 12:53

Commented on src/main/java/net/glowstone/generator/ground/MesaGroundGenerator.java line 60

I think this is not the way we are supposed to format this. The previous version was what we were aiming for, as far as I am aware.

In GitLab by @JimVliet on May 18, 2020, 12:54

Commented on src/main/java/net/glowstone/generator/ground/MesaGroundGenerator.java line 169

Same here.

In GitLab by @julian9499 on May 18, 2020, 13:03

Commented on src/main/java/net/glowstone/generator/ground/MesaGroundGenerator.java line 74

Do you want to cast this to an int or math.round it?

In GitLab by @swabbur on May 18, 2020, 13:10

Commented on src/main/java/net/glowstone/generator/ground/MesaGroundGenerator.java line 60

The previous version wasn't correct either. I think it should be chopped (each parameter on a separate line).

In GitLab by @swabbur on May 18, 2020, 13:11

Commented on src/main/java/net/glowstone/generator/ground/MesaGroundGenerator.java line 74

Round still returns a double, right?

In GitLab by @JimVliet on May 18, 2020, 13:24

Commented on src/main/java/net/glowstone/generator/ground/MesaGroundGenerator.java line 60

Yes, that's correct.

In GitLab by @swabbur on May 18, 2020, 13:26

Commented on src/main/java/net/glowstone/generator/ground/MesaGroundGenerator.java line 74

Also, to keep functionality identical, if would be better to use floor.

In GitLab by @wubero on May 18, 2020, 13:26

Commented on src/main/java/net/glowstone/generator/ground/MesaGroundGenerator.java line 74

Math.round returns a long

In GitLab by @wubero on May 18, 2020, 13:28

Commented on src/main/java/net/glowstone/generator/ground/MesaGroundGenerator.java line 60

changed this line in version 3 of the diff

In GitLab by @wubero on May 18, 2020, 13:28

Commented on src/main/java/net/glowstone/generator/ground/MesaGroundGenerator.java line 169

changed this line in version 3 of the diff

In GitLab by @wubero on May 18, 2020, 13:28

added 1 commit

a1ab70c8 - Change parameters in the generateTerrainColumn method

Compare with previous version

In GitLab by @wubero on May 18, 2020, 13:29

Commented on src/main/java/net/glowstone/generator/ground/MesaGroundGenerator.java line 74

If we want to keep the functionality indentical we shouldn't change this.

In GitLab by @wubero on May 18, 2020, 13:29

resolved all threads

In GitLab by @swabbur on May 18, 2020, 13:47

Commented on src/main/java/net/glowstone/generator/ground/MesaGroundGenerator.java line 147

Two whitelines may be a bit much.

In GitLab by @swabbur on May 18, 2020, 13:56

resolved all threads

In GitLab by @swabbur on May 18, 2020, 13:57

Commented on src/main/java/net/glowstone/generator/ground/MesaGroundGenerator.java line 147

changed this line in version 4 of the diff

In GitLab by @swabbur on May 18, 2020, 13:57

added 1 commit

49aaa5fa - Remove redundant whitelines

Compare with previous version

In GitLab by @swabbur on May 18, 2020, 13:57

enabled an automatic merge when the pipeline for 49aaa5fa76894586db0f8a6c0344c86b810563a4 succeeds

In GitLab by @swabbur on May 18, 2020, 14:05

merged

In GitLab by @swabbur on May 18, 2020, 14:05

mentioned in commit f6967d417ea679388b210859f47e3370ef955d72

atlarge-research / opencraft

Mesa biome bugfix - [merged] #141