Fix gravity and entity-world collision for all entities - [merged] #144

Closed jdonkervliet closed 4 years ago

In GitLab by @julian9499 on May 19, 2020, 24:18

Merges feature/fix-gravity -> development

This merge request adds the feature for mobs to be affected by gravity and collide with blocks in the world. The gravity implementation was already present but is largely reworked to accommodate for the collision checking and response. The collision checking is achieved by using the swept-AABB method. This method also provides the collision response for the entity. Bounding box generation for blocks has been reworked to accommodate for different types of blocks as well.

In GitLab by @JimVliet on May 19, 2020, 10:37

Commented on src/test/java/net/glowstone/entity/physics/BlockBoundingBoxTest.java line 35

This tearDown seems unnecessary, is there a particular reason these variables have to be set to null?

In GitLab by @JimVliet on May 19, 2020, 10:39

Commented on src/test/java/net/glowstone/entity/physics/EntityBoundingBoxTest.java line 16

Avoid the star imports in the tests classes too.

In GitLab by @JimVliet on May 19, 2020, 10:41

Commented on src/main/java/net/glowstone/GlowWorld.java line 9

The java util package is pretty enormous though: https://docs.oracle.com/javase/8/docs/api/java/util/package-summary.html

In GitLab by @julian9499 on May 19, 2020, 10:43

Commented on src/main/java/net/glowstone/entity/physics/EntityBoundingBox.java line 73

Done

In GitLab by @julian9499 on May 19, 2020, 10:43

Commented on src/main/java/net/glowstone/entity/physics/EntityBoundingBox.java line 71

added

In GitLab by @julian9499 on May 19, 2020, 10:43

Commented on src/test/java/net/glowstone/entity/GlowEntityTest.java line 17

changed this line in version 3 of the diff

In GitLab by @julian9499 on May 19, 2020, 10:43

Commented on src/test/java/net/glowstone/entity/GlowEntityTest.java line 58

changed this line in version 3 of the diff

In GitLab by @julian9499 on May 19, 2020, 10:44

added 3 commits

b96ba1f6 - fix glowEntity syntax comments
e79db780 - add javadoc to vectors
cde24f0b - entity bounding box

Compare with previous version

In GitLab by @julian9499 on May 19, 2020, 11:07

Commented on src/main/java/net/glowstone/entity/physics/EntityBoundingBox.java line 60

changed this line in version 4 of the diff

In GitLab by @julian9499 on May 19, 2020, 11:07

added 1 commit

e4460d9e - change logic to use math class

Compare with previous version

In GitLab by @julian9499 on May 19, 2020, 11:07

Commented on src/main/java/net/glowstone/entity/physics/EntityBoundingBox.java line 60

Changed it

In GitLab by @wubero on May 19, 2020, 11:11

Commented on src/main/java/net/glowstone/GlowWorld.java line 9

yeah you're right, shouldn't be a star

In GitLab by @julian9499 on May 19, 2020, 11:15

Commented on src/main/java/net/glowstone/entity/physics/EntityBoundingBox.java line 45

renamed

In GitLab by @julian9499 on May 19, 2020, 11:16

Commented on src/main/java/net/glowstone/entity/physics/EntityBoundingBox.java line 29

changed this line in version 5 of the diff

In GitLab by @julian9499 on May 19, 2020, 11:16

Commented on src/main/java/net/glowstone/entity/physics/EntityBoundingBox.java line 45

changed this line in version 5 of the diff

In GitLab by @julian9499 on May 19, 2020, 11:16

Commented on src/main/java/net/glowstone/entity/physics/EntityBoundingBox.java line 140

changed this line in version 5 of the diff

In GitLab by @julian9499 on May 19, 2020, 11:16

Commented on src/main/java/net/glowstone/entity/physics/EntityBoundingBox.java line 29

fixed

In GitLab by @julian9499 on May 19, 2020, 11:16

added 1 commit

052f6f19 - fix entity bounding box comments

Compare with previous version

In GitLab by @julian9499 on May 19, 2020, 11:17

Commented on src/test/java/net/glowstone/entity/physics/BlockBoundingBoxTest.java line 35

It saves on memory https://examples.javacodegeeks.com/core-java/junit/junit-setup-teardown-example/

In GitLab by @julian9499 on May 19, 2020, 11:17

Commented on src/test/java/net/glowstone/entity/physics/BlockBoundingBoxTest.java line 21

Jup

In GitLab by @swabbur on May 19, 2020, 11:20

Commented on src/test/java/net/glowstone/entity/physics/BlockBoundingBoxTest.java line 35

Premature optimization is the root of all evil ;)

In GitLab by @swabbur on May 19, 2020, 11:29

Commented on src/test/java/net/glowstone/entity/physics/BlockBoundingBoxTest.java line 35

And your link doesn't provide any information on the topic...

In GitLab by @julian9499 on May 19, 2020, 11:42

Commented on src/main/java/net/glowstone/entity/GlowEntity.java line 1154

changed this line in version 6 of the diff

In GitLab by @julian9499 on May 19, 2020, 11:42

Commented on src/main/java/net/glowstone/GlowWorld.java line 9

changed this line in version 6 of the diff

In GitLab by @julian9499 on May 19, 2020, 11:42

Commented on src/main/java/net/glowstone/GlowWorld.java line 60

changed this line in version 6 of the diff

In GitLab by @julian9499 on May 19, 2020, 11:42

Commented on src/main/java/net/glowstone/GlowWorld.java line 9

done

In GitLab by @julian9499 on May 19, 2020, 11:42

Commented on src/test/java/net/glowstone/entity/physics/BlockBoundingBoxTest.java line 21

changed this line in version 6 of the diff

In GitLab by @julian9499 on May 19, 2020, 11:42

added 3 commits

440be94b - add private
925baa7b - fix vectors class syntax error
21944e4f - fix imports

Compare with previous version

In GitLab by @julian9499 on May 19, 2020, 11:43

Commented on src/main/java/net/glowstone/GlowWorld.java line 1652

changed this line in version 7 of the diff

In GitLab by @julian9499 on May 19, 2020, 11:44

added 1 commit

4f5d4d05 - revert glowworld.java state to development branch

Compare with previous version

In GitLab by @julian9499 on May 19, 2020, 11:50

Commented on src/main/java/net/glowstone/block/GlowBlock.java line 596

No the fence gates don't I changed this

In GitLab by @julian9499 on May 19, 2020, 11:51

Commented on src/main/java/net/glowstone/block/GlowBlock.java line 598

True, removed

In GitLab by @julian9499 on May 19, 2020, 11:53

Commented on src/main/java/net/glowstone/block/GlowBlock.java line 604

Removed

In GitLab by @julian9499 on May 19, 2020, 11:53

Commented on src/main/java/net/glowstone/block/GlowBlock.java line 605

Nope, removed them from isfence

In GitLab by @julian9499 on May 19, 2020, 12:03

Commented on src/main/java/net/glowstone/block/GlowBlock.java line 613

Done