Underwater penalty bugfix - [merged]

[jdonkervliet]

In GitLab by @wubero on May 19, 2020, 12:28

Merges bugfix/underwater-penalty -> development

This merge request closes issue #62 and implements underwater mining penalty.

[jdonkervliet]

In GitLab by @wubero on May 19, 2020, 12:29

changed the description

[jdonkervliet]

In GitLab by @larsdetombe on May 19, 2020, 12:50

Commented on src/main/java/net/glowstone/entity/GlowPlayer.java line 3382

There is no need for a whiteline here right?

[jdonkervliet]

In GitLab by @wubero on May 19, 2020, 14:53

added 1 commit

• 066d109d - Fix issue in test and add test for mining off ground

Compare with previous version

[jdonkervliet]

In GitLab by @wubero on May 19, 2020, 14:54

Commented on src/main/java/net/glowstone/entity/GlowPlayer.java line 3382

There are multiple code blocks here so there should be

[jdonkervliet]

In GitLab by @wubero on May 19, 2020, 14:54

resolved all threads

[jdonkervliet]

In GitLab by @larsdetombe on May 19, 2020, 15:07

Commented on src/main/java/net/glowstone/entity/GlowPlayer.java line 3382

not within this if statement, it only seems like uncessary whitelines to me. However, if you think it looks beter this way you can keep them here

[jdonkervliet]

In GitLab by @larsdetombe on May 19, 2020, 15:10

resolved all threads

[jdonkervliet]

In GitLab by @swabbur on May 19, 2020, 15:37

merged

[jdonkervliet]

In GitLab by @swabbur on May 19, 2020, 15:37

mentioned in commit a3528997c397d4b04aa015ef3f8438e71154afbd

[jdonkervliet]

In GitLab by @julian9499 on May 19, 2020, 15:43

Commented on src/main/java/net/glowstone/entity/GlowPlayer.java line 3416

Is this not the case with lava?