Mining speed bugfix - [merged] #147

Closed jdonkervliet closed 4 years ago

In GitLab by @wubero on May 20, 2020, 10:45

Merges bugfix/mining-speed -> development

This merge request fixes issue #64 When in lava mining speed is reduced. When having a potion effect for slow digging the mining speed is reduced.

In GitLab by @wubero on May 20, 2020, 10:58

added 1 commit

d61347fa - Fix checkstyle error

Compare with previous version

In GitLab by @wubero on May 20, 2020, 11:17

added 1 commit

4491896b - Implement haste effect

Compare with previous version

In GitLab by @julian9499 on May 20, 2020, 11:48

Commented on src/main/java/net/glowstone/entity/GlowPlayer.java line 3426

Water worker also works under lava

In GitLab by @wubero on May 20, 2020, 11:56

Commented on src/main/java/net/glowstone/entity/GlowPlayer.java line 3426

changed this line in version 4 of the diff

In GitLab by @wubero on May 20, 2020, 11:56

added 1 commit

a4369367 - Water worker now also works in lava

Compare with previous version

In GitLab by @wubero on May 20, 2020, 11:56

Commented on src/main/java/net/glowstone/entity/GlowPlayer.java line 3426

You're right, it is fixed now

In GitLab by @wubero on May 20, 2020, 11:56

resolved all threads

In GitLab by @JimVliet on May 20, 2020, 13:39

Commented on src/main/java/net/glowstone/entity/GlowPlayer.java line 3421

As discussed previously, I am in favour of declaring these magic numbers as constants. Otherwise, it will be unclear exactly what this number is supposed to represent.

In GitLab by @wubero on May 20, 2020, 19:10

Commented on src/main/java/net/glowstone/entity/GlowPlayer.java line 3421

changed this line in version 5 of the diff

In GitLab by @wubero on May 20, 2020, 19:10

added 1 commit

625d1da3 - Rename magic numbers in setDigging method

Compare with previous version

In GitLab by @wubero on May 20, 2020, 19:11

Commented on src/main/java/net/glowstone/entity/GlowPlayer.java line 3421

I made constants for this number, the 3.0 below and the 0.2 below that.

In GitLab by @wubero on May 20, 2020, 19:11

resolved all threads

In GitLab by @JimVliet on May 20, 2020, 20:23

If you rebase/merge your branch with development I will give a thumbs up.

In GitLab by @swabbur on May 20, 2020, 20:26

Commented on src/main/java/net/glowstone/entity/GlowPlayer.java line 3442

Are there any status effects to be done?

In GitLab by @larsdetombe on May 20, 2020, 20:36

Commented on src/main/java/net/glowstone/entity/GlowPlayer.java line 3442

I assume slow and fast digging are the same as haste and mining fatigue right? As conduit power was introduced in minecraft version 1.13, this should be everything I think.

In GitLab by @wubero on May 21, 2020, 10:02

Commented on src/main/java/net/glowstone/entity/GlowPlayer.java line 3442

I think this is everything for mining but there are a lot more status effect that still need to be done in the project. There are not TODO's in these methods so I thought I'd leave it here so that people (we) wouldn't forget

In GitLab by @swabbur on May 21, 2020, 10:03

Commented on src/main/java/net/glowstone/entity/GlowPlayer.java line 3442

The problem is that those status effects influence very different gameplay mechanics. I would prefer if the TODO were removed here, as this method is now complete. Would it be possible to place it at a more appropriate place? Or create an issue for it on the board?

In GitLab by @wubero on May 21, 2020, 10:51

Commented on src/main/java/net/glowstone/entity/GlowPlayer.java line 3442

I'll create an issue for this on the board

In GitLab by @wubero on May 21, 2020, 10:51

resolved all threads

In GitLab by @wubero on May 21, 2020, 11:01

Commented on src/main/java/net/glowstone/entity/GlowPlayer.java line 3442

changed this line in version 6 of the diff

In GitLab by @wubero on May 21, 2020, 11:01

added 33 commits

625d1da3...400b08b2 - 31 commits from branch development
78c5b9c5 - Merge remote-tracking branch 'origin/development' into bugfix/mining-speed
cccac54b - Place TODO: status effects in the right method

Compare with previous version

In GitLab by @swabbur on May 21, 2020, 11:03

Commented on src/main/java/net/glowstone/entity/GlowPlayer.java line 3420

Why does haste include 'effect' while the others do not?

In GitLab by @swabbur on May 21, 2020, 11:06

resolved all threads

In GitLab by @wubero on May 21, 2020, 11:07

Commented on src/main/java/net/glowstone/entity/GlowPlayer.java line 3420

changed this line in version 7 of the diff

In GitLab by @wubero on May 21, 2020, 11:07

added 1 commit