search

atlarge-research / opencraft

Other
5 stars 2 forks source link

Fix banner placement - [merged] #150

Closed jdonkervliet closed 4 years ago

jdonkervliet commented 4 years ago

In GitLab by @larsdetombe on May 22, 2020, 13:17

Merges bugfix/fix-banner -> development

This merge request resolves issue #58

Something went wrong in placing the banner in the ItemTable, causing the block type to be null. Right clicking on a surface to place the banner was not working properly and the specific block type was not set.

placing a wall banner on a wall with a block directly below it might look like a bug, however in the original Minecraft client this is also possible.

jdonkervliet commented 4 years ago

In GitLab by @larsdetombe on May 22, 2020, 13:33

changed the description

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 22, 2020, 14:06

Commented on src/main/java/net/glowstone/block/itemtype/ItemBanner.java line 22

Could you store the ItemTable instance in a temporary value (you are using it multiple times).

jdonkervliet commented 4 years ago

In GitLab by @larsdetombe on May 22, 2020, 14:14

Commented on src/main/java/net/glowstone/block/itemtype/ItemBanner.java line 22

changed this line in version 2 of the diff

jdonkervliet commented 4 years ago

In GitLab by @larsdetombe on May 22, 2020, 14:14

added 1 commit

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @JimVliet on May 22, 2020, 14:35

merged

jdonkervliet commented 4 years ago

In GitLab by @JimVliet on May 22, 2020, 14:35

mentioned in commit ea43eabe10dea2325426a37e503c6f0be69a56aa