Guava broker implementation - [merged]

[jdonkervliet]

In GitLab by @wubero on May 22, 2020, 13:51

Merges feature/guava-listener -> development

This merge request solves issue #13 There is a lot of duplicate code right now but it is nice to have the functionality in the development branch. A seperate issue and merge request will be made for solving the duplicate code issue.

[jdonkervliet]

In GitLab by @wubero on May 22, 2020, 14:00

changed title from Guava {-listener feature-} to Guava {+broker implementation+}

[jdonkervliet]

In GitLab by @wubero on May 22, 2020, 14:00

changed the description

[jdonkervliet]

In GitLab by @wubero on May 22, 2020, 14:41

added 1 commit

• d513497b - Add guava channel tests

Compare with previous version

[jdonkervliet]

In GitLab by @larsdetombe on May 22, 2020, 15:08

Commented on src/main/java/net/glowstone/messaging/brokers/guava/GuavaBroker.java line 18

shouldn't this be a ConcurrentMap?

[jdonkervliet]

In GitLab by @wubero on May 22, 2020, 15:11

Commented on src/main/java/net/glowstone/messaging/brokers/guava/GuavaBroker.java line 18

It makes it a ConcurrentMap in the constructor

[jdonkervliet]

In GitLab by @larsdetombe on May 22, 2020, 15:12

Commented on src/main/java/net/glowstone/messaging/brokers/guava/GuavaBroker.java line 18

Oops I missed that!

[jdonkervliet]

In GitLab by @larsdetombe on May 22, 2020, 15:12

resolved all threads

[jdonkervliet]

In GitLab by @larsdetombe on May 22, 2020, 15:18

merged

[jdonkervliet]

In GitLab by @larsdetombe on May 22, 2020, 15:18

mentioned in commit e79ac39c8752fbb35006b3042cd065add6af9e48