search

atlarge-research / opencraft

Other
4 stars 2 forks source link

Remove code duplication from brokers - [merged] #156

Closed jdonkervliet closed 4 years ago

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 26, 2020, 12:56

Merges feature/combine-concurrent-guava -> development

This feature adds a ChannelBroker class that can be created with a channel factory. This allows the channel broker to work with different channels as long as they implement the Channel interface.

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 26, 2020, 12:58

added 1 commit

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 26, 2020, 13:00

changed title from {-Combine concurrent broker and guava broker into a general ConcurrentBroker that implements channelbroker-} to {+Remove code duplication from brokers+}

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 26, 2020, 13:02

Commented on src/main/java/net/glowstone/messaging/brokers/ChannelFactory.java line 14

Missing whiteline.

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 26, 2020, 13:02

Commented on src/main/java/net/glowstone/messaging/brokers/ChannelFactory.java line 12

Missing JavaDoc.

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 26, 2020, 13:02

Commented on src/main/java/net/glowstone/messaging/brokers/ChannelBroker.java line 32

Redundant whiteline.

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 26, 2020, 13:03

Commented on src/test/java/net/glowstone/messaging/brokers/jms/JmsBrokerTest.java line 41

Redundant whiteline.

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 26, 2020, 13:22

Commented on src/main/java/net/glowstone/messaging/brokers/ChannelBroker.java line 32

changed this line in version 3 of the diff

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 26, 2020, 13:22

Commented on src/test/java/net/glowstone/messaging/brokers/jms/JmsBrokerTest.java line 41

changed this line in version 3 of the diff

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 26, 2020, 13:22

added 1 commit

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 26, 2020, 13:22

resolved all threads

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 26, 2020, 14:45

merged

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 26, 2020, 14:45

mentioned in commit d329d595a61bc06ebcb5f920624bad183be12d82