Entity updates - [merged] #161

Closed jdonkervliet closed 4 years ago

In GitLab by @swabbur on May 27, 2020, 19:54

Merges feature/entities -> development

Resolve issue #6

As entity spawning will require some more work, I've decided to split it into two separate merge requests. For now, this branch disables leashes such that all entity updates can be performed at once. After that, update messages for all entities are generated and broadcast via the messaging system, such that only one message needs to be generated per entity instead of one per entity per player.

In GitLab by @wubero on May 27, 2020, 20:39

Commented on src/main/java/net/glowstone/GlowWorld.java line 646

Why is the skylight defined outside of the if and for statements? Unless I missed something it's only used inside

In GitLab by @wubero on May 27, 2020, 20:41

Commented on src/main/java/net/glowstone/entity/GlowEntity.java line 954

Are these comments still relevent? Since the code below it was deleted

In GitLab by @swabbur on May 27, 2020, 20:54

added 4 commits

dd5b9ea5...c1e9a8b8 - 3 commits from branch development
ff8a8c53 - Merge branch 'development' into 'feature/entities'

Compare with previous version

In GitLab by @larsdetombe on May 27, 2020, 21:06

Commented on src/main/java/net/glowstone/entity/GlowEntity.java line 962

Is this not needed anymore? Or did leashes on animals not work in the first place? Because it seems like we removed functionality.

In GitLab by @JimVliet on May 27, 2020, 21:23

Commented on src/main/java/net/glowstone/entity/GlowEntity.java line 962

In GitLab by @JimVliet on May 27, 2020, 21:24

Commented on src/main/java/net/glowstone/entity/GlowEntity.java line 962

Read the description :P

In GitLab by @larsdetombe on May 27, 2020, 21:28

Commented on src/main/java/net/glowstone/entity/GlowEntity.java line 962

I should get some sleep, completely read over that somehow. I should also have checked the issues. I'll resolve this thread.

In GitLab by @swabbur on May 27, 2020, 21:56

Commented on src/main/java/net/glowstone/GlowWorld.java line 646

There was not much of a reason, I've placed it inside the runnable now, such that it is up-to-date once the chunk message is generated.

In GitLab by @swabbur on May 27, 2020, 22:01

Commented on src/main/java/net/glowstone/GlowWorld.java line 646

changed this line in version 3 of the diff

In GitLab by @swabbur on May 27, 2020, 22:01

added 2 commits

8a9f48b6 - Move environment check into ChunkRunnable
18495ff6 - Merge local changes with remote changes of the feature/entities branch

Compare with previous version

In GitLab by @swabbur on May 27, 2020, 22:03

Commented on src/main/java/net/glowstone/entity/GlowEntity.java line 954

Only the part on leashes was removed, the other part was merely refactored. However, I get the confusion as Gitlab sees it as a removal and addition instead of a change. The comment remains correct as it was associated with the passengers, not the leash.

In GitLab by @wubero on May 28, 2020, 10:03

resolved all threads

In GitLab by @swabbur on May 28, 2020, 10:57

Commented on src/main/java/net/glowstone/GlowWorld.java line 921

This would break whenever the policy is altered. It might be better to directly broadcast based on the entity instead of the chunk.

In GitLab by @swabbur on May 28, 2020, 10:57

Commented on src/main/java/net/glowstone/GlowWorld.java line 937

This would also break, as it is no longer possible to send a destroy message for a single entity.

In GitLab by @swabbur on May 28, 2020, 11:08

added 1 commit

d56691bb - Broadcast updates and removals via the correct publisher

Compare with previous version

In GitLab by @swabbur on May 28, 2020, 11:09

resolved all threads

In GitLab by @JimVliet on May 28, 2020, 11:09

enabled an automatic merge when the pipeline for d56691bbc1ece98ba75d920f1219554b8e1b13f2 succeeds

In GitLab by @JimVliet on May 28, 2020, 11:40

merged

In GitLab by @JimVliet on May 28, 2020, 11:40

mentioned in commit ecb8146d39d3170b28491f314fea68323d5a47b3

atlarge-research / opencraft

Entity updates - [merged] #161