Refactor nether portal code - [merged]

[jdonkervliet]

In GitLab by @larsdetombe on Jun 17, 2020, 16:13

Merges feature/refactor-nether-portal -> development

This merge request solves issue #113

[jdonkervliet]

In GitLab by @swabbur on Jun 17, 2020, 17:03

Commented on src/main/java/net/glowstone/block/itemtype/ItemFlintAndSteel.java line 96

It might be neater to write this if-statement the same as the previous two (as a negation).

// ...

if (!checkInsidePortal(cornerBlock, direction, width, height)) {
    return false;
}

fillPortal(cornerBlock, direction, width, height, player);
return true;

[jdonkervliet]

In GitLab by @larsdetombe on Jun 17, 2020, 17:09

Commented on src/main/java/net/glowstone/block/itemtype/ItemFlintAndSteel.java line 96

I hadn't thought about that, I will change it. It is indeed better this way.

[jdonkervliet]

In GitLab by @swabbur on Jun 17, 2020, 17:11

resolved all threads

[jdonkervliet]

In GitLab by @larsdetombe on Jun 17, 2020, 17:31

added 1 commit

• bbd41c40 - Change if-else to single if statement

Compare with previous version

[jdonkervliet]

In GitLab by @wubero on Jun 17, 2020, 17:37

enabled an automatic merge when the pipeline for bbd41c402f0e28245e330759daf576b184e23998 succeeds

[jdonkervliet]

In GitLab by @wubero on Jun 17, 2020, 17:44

merged

[jdonkervliet]

In GitLab by @wubero on Jun 17, 2020, 17:44

mentioned in commit 29f64f949903e71685e4968cda7fe32294bf293c