WIP: Development benchmark DO NOT MERGE THIS MR IS FOR DEMONSTRATION PURPOSES ONLY - Githubissues

atlarge-research / opencraft

Other

5 stars 2 forks source link

WIP: Development benchmark DO NOT MERGE THIS MR IS FOR DEMONSTRATION PURPOSES ONLY #189

Closed jdonkervliet closed 4 years ago

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on Jun 21, 2020, 15:12

jdonkervliet commented 4 years ago

In GitLab by @swabbur on Jun 21, 2020, 16:25

Commented on src/main/java/net/glowstone/Benchmarker.java line 71

As this only sets the name, it should be named setName.

jdonkervliet commented 4 years ago

In GitLab by @swabbur on Jun 21, 2020, 16:25

Commented on src/main/java/net/glowstone/Benchmarker.java line 46

Constants like these should be static.

jdonkervliet commented 4 years ago

In GitLab by @swabbur on Jun 21, 2020, 16:26

Commented on src/main/java/net/glowstone/Benchmarker.java line 44

Prefer initializing non-constant values in the constructor.

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on Jun 21, 2020, 16:58

Commented on src/main/java/net/glowstone/Benchmarker.java line 37

changed this line in version 7 of the diff

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on Jun 21, 2020, 16:58

Commented on src/main/java/net/glowstone/Benchmarker.java line 19

changed this line in version 7 of the diff

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on Jun 21, 2020, 16:58

Commented on src/main/java/net/glowstone/Benchmarker.java line 71

changed this line in version 7 of the diff

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on Jun 21, 2020, 16:58

Commented on src/main/java/net/glowstone/Benchmarker.java line 46

changed this line in version 7 of the diff

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on Jun 21, 2020, 16:58

Commented on src/main/java/net/glowstone/Benchmarker.java line 44

changed this line in version 7 of the diff

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on Jun 21, 2020, 16:58

added 1 commit

578e4ae5 - minor changes

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @swabbur on Jun 22, 2020, 22:46

added 1 commit

ea56cf97 - Make all chunk, block, and entity updates parallel

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @swabbur on Jun 22, 2020, 22:48

added 1 commit

63fbd9ca - Pulse entities in parallel

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on Jun 23, 2020, 24:52

added 10 commits

63fbd9ca...67688c38 - 5 commits from branch development
90a4d609 - disable physics
89a75fbd - Merge branch 'development-benchmark' of...
c5ab7de6 - Merge branch 'development-benchmark' of...
1c0342bb - change name
2c404324 - fix merge conflicts

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @swabbur on Jun 24, 2020, 23:35

closed

Previous